From 7d972994fb028ff5b923bc0f364106be790fb96d Mon Sep 17 00:00:00 2001 From: Alex Danoff Date: Thu, 6 Apr 2023 11:49:36 -0700 Subject: [PATCH] W3CPointerEvents: use description to indicate HW requirements for tests (#36840) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36840 Changelog: [Internal] - W3CPointerEvents: use description to indicate HW requirements for tests As title. This lets users/testers know whether additional hardware is required to run each test and can give info on the test status (e.g. whether it's expected to fail). Tests with no description should be assumed to work without any special requirements. Reviewed By: vincentriemer Differential Revision: D44687709 fbshipit-source-id: 09c2308614566c8c64db6329701a42fd48b77ccf --- .../Experimental/W3CPointerEventsExample.js | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/packages/rn-tester/js/examples/Experimental/W3CPointerEventsExample.js b/packages/rn-tester/js/examples/Experimental/W3CPointerEventsExample.js index 725379f1320d..c8b293fbb4b4 100644 --- a/packages/rn-tester/js/examples/Experimental/W3CPointerEventsExample.js +++ b/packages/rn-tester/js/examples/Experimental/W3CPointerEventsExample.js @@ -155,7 +155,7 @@ export default { examples: [ { name: 'pointerevent_attributes_hoverable_pointers', - description: '', + description: 'Requires physical device + mouse', title: 'WPT 1: Pointer Events hoverable pointer attributes test', render(): React.Node { return ; @@ -163,7 +163,6 @@ export default { }, { name: 'pointerevent_attributes_nohover_pointers', - description: '', title: 'WPT 2: Pointer Events no-hover pointer attributes test', render(): React.Node { return ; @@ -171,7 +170,6 @@ export default { }, { name: 'pointerevent_pointermove', - description: '', title: 'WPT 3: PointerMove test', render(): React.Node { return ; @@ -179,7 +177,7 @@ export default { }, { name: 'pointerevent_primary_touch_pointer', - description: '', + description: 'Requires multi-touch (difficult on emulator)', title: 'WPT 4: Pointer Event primary touch pointer test', render(): React.Node { return ; @@ -187,7 +185,7 @@ export default { }, { name: 'pointerevent_pointermove_on_chorded_mouse_button', - description: '', + description: 'Requires physical device + mouse', title: 'WPT 5: PointerEvents pointermove on button state changes', render(): React.Node { return ; @@ -195,7 +193,8 @@ export default { }, { name: 'pointerevent_pointermove_across', - description: '', + description: + 'Works best with a mouse, can be done with touch if you start outside the indicated elements', title: 'WPT 6: Pointermove handling across elements', render(): React.Node { return ; @@ -203,7 +202,6 @@ export default { }, { name: 'pointerevent_pointermove_event_order', - description: '', title: 'WPT 7: PointerEvent - pointermove event order', render(): React.Node { return ; @@ -211,7 +209,6 @@ export default { }, { name: 'pointerevent_pointermove_between', - description: '', title: 'WPT 8: Pointermove handling between elements', render(): React.Node { return ; @@ -219,7 +216,6 @@ export default { }, { name: 'pointerevent_pointerover_out', - description: '', title: 'WPT 9: PointerOver/PointerOut handling', render(): React.Node { return ; @@ -227,7 +223,7 @@ export default { }, { name: 'pointerevent_layout_change_should_fire_pointerover', - description: '', + description: 'Currently expected to fail', title: 'WPT 10: Layout change should fire pointerover', render(): React.Node { return ; @@ -235,7 +231,6 @@ export default { }, { name: 'pointerevent_pointercancel_touch', - description: '', title: 'WPT 11: Pointer Events pointercancel Tests', render(): React.Node { return ;