diff --git a/packages/react-native-codegen/e2e/__tests__/modules/__snapshots__/GenerateModuleH-test.js.snap b/packages/react-native-codegen/e2e/__tests__/modules/__snapshots__/GenerateModuleH-test.js.snap index e7d50c7f5c1f..817b6366da19 100644 --- a/packages/react-native-codegen/e2e/__tests__/modules/__snapshots__/GenerateModuleH-test.js.snap +++ b/packages/react-native-codegen/e2e/__tests__/modules/__snapshots__/GenerateModuleH-test.js.snap @@ -37,9 +37,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeArrayTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeArrayTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -98,9 +100,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeBooleanTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeBooleanTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -151,9 +155,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeCallbackTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeCallbackTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -434,9 +440,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"NativeEnumTurboModule\\"; + protected: NativeEnumTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"NativeEnumTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeEnumTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -523,9 +531,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeNullableTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeNullableTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -608,9 +618,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeNumberTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeNumberTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -664,9 +676,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeObjectTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeObjectTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -740,9 +754,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeOptionalObjectTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeOptionalObjectTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -832,9 +848,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"NativePartialAnnotationTurboModule\\"; + protected: NativePartialAnnotationTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"NativePartialAnnotationTurboModule\\", jsInvoker), + : TurboModule(std::string{NativePartialAnnotationTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -901,9 +919,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativePromiseTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativePromiseTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1002,9 +1022,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1191,9 +1213,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleArrays\\"; + protected: NativeSampleTurboModuleArraysCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleArrays\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleArraysCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1380,9 +1404,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleNullable\\"; + protected: NativeSampleTurboModuleNullableCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleNullable\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleNullableCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1571,9 +1597,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleNullableAndOptional\\"; + protected: NativeSampleTurboModuleNullableAndOptionalCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleNullableAndOptional\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleNullableAndOptionalCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1762,9 +1790,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleOptional\\"; + protected: NativeSampleTurboModuleOptionalCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleOptional\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleOptionalCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1903,9 +1933,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeStringTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeStringTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1980,9 +2012,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeArrayTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeArrayTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2041,9 +2075,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeBooleanTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeBooleanTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2094,9 +2130,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeCallbackTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeCallbackTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2377,9 +2415,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"NativeEnumTurboModule\\"; + protected: NativeEnumTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"NativeEnumTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeEnumTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2466,9 +2506,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeNullableTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeNullableTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2551,9 +2593,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeNumberTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeNumberTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2607,9 +2651,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeObjectTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeObjectTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2683,9 +2729,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeOptionalObjectTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeOptionalObjectTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2775,9 +2823,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"NativePartialAnnotationTurboModule\\"; + protected: NativePartialAnnotationTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"NativePartialAnnotationTurboModule\\", jsInvoker), + : TurboModule(std::string{NativePartialAnnotationTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2844,9 +2894,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativePromiseTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativePromiseTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -2945,9 +2997,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -3134,9 +3188,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleArrays\\"; + protected: NativeSampleTurboModuleArraysCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleArrays\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleArraysCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -3323,9 +3379,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleNullable\\"; + protected: NativeSampleTurboModuleNullableCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleNullable\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleNullableCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -3514,9 +3572,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleNullableAndOptional\\"; + protected: NativeSampleTurboModuleNullableAndOptionalCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleNullableAndOptional\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleNullableAndOptionalCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -3705,9 +3765,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleOptional\\"; + protected: NativeSampleTurboModuleOptionalCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleOptional\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleOptionalCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -3846,9 +3908,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeStringTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeStringTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: diff --git a/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js b/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js index e4d8f53b5b5d..114e4ce17005 100644 --- a/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js +++ b/packages/react-native-codegen/src/generators/modules/GenerateModuleH.js @@ -74,9 +74,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = "${moduleName}"; + protected: ${hasteModuleName}CxxSpec(std::shared_ptr jsInvoker) - : TurboModule("${moduleName}", jsInvoker), + : TurboModule(std::string{${hasteModuleName}CxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: diff --git a/packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleH-test.js.snap b/packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleH-test.js.snap index be1d454013a1..f050f49e42cc 100644 --- a/packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleH-test.js.snap +++ b/packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleH-test.js.snap @@ -36,9 +36,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -104,9 +106,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -349,9 +353,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModuleCxx\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModuleCxx\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -450,9 +456,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -580,9 +588,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"AliasTurboModule\\"; + protected: AliasTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"AliasTurboModule\\", jsInvoker), + : TurboModule(std::string{AliasTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -897,9 +907,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"CameraRollManager\\"; + protected: NativeCameraRollManagerCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"CameraRollManager\\", jsInvoker), + : TurboModule(std::string{NativeCameraRollManagerCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1118,9 +1130,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"ExceptionsManager\\"; + protected: NativeExceptionsManagerCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"ExceptionsManager\\", jsInvoker), + : TurboModule(std::string{NativeExceptionsManagerCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1319,9 +1333,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1492,9 +1508,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule\\"; + protected: NativeSampleTurboModuleCxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModuleCxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: @@ -1537,9 +1555,11 @@ public: return delegate_.get(rt, propName); } + static constexpr std::string_view kModuleName = \\"SampleTurboModule2\\"; + protected: NativeSampleTurboModule2CxxSpec(std::shared_ptr jsInvoker) - : TurboModule(\\"SampleTurboModule2\\", jsInvoker), + : TurboModule(std::string{NativeSampleTurboModule2CxxSpec::kModuleName}, jsInvoker), delegate_(static_cast(this), jsInvoker) {} private: