Initial implementation of adjustsFontSizeToFit. #4026

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
@MattFoley
Contributor

MattFoley commented Nov 10, 2015

No description provided.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 10, 2015

Contributor

It had been way too long to fix it up myself, so I've reopened the PR. Here's the original. #2327

Contributor

MattFoley commented Nov 10, 2015

It had been way too long to fix it up myself, so I've reopened the PR. Here's the original. #2327

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 10, 2015

By analyzing the blame information on this pull request, we identified @nicklockwood, @sahrens and @a2 to be potential reviewers.

By analyzing the blame information on this pull request, we identified @nicklockwood, @sahrens and @a2 to be potential reviewers.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 10, 2015

Contributor

This should be stable enough to merge now.

Contributor

MattFoley commented Nov 10, 2015

This should be stable enough to merge now.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 10, 2015

Contributor

Keeping this squashed on master led to a missed file. Corrected.

Contributor

MattFoley commented Nov 10, 2015

Keeping this squashed on master led to a missed file. Corrected.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 10, 2015

@MattFoley updated the pull request.

@MattFoley updated the pull request.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 10, 2015

Contributor

@nicklockwood, @sahrens, @a2 Correct me if I'm wrong, but the tests failing after my last commit/squash are not due to my code changes, correct?

Contributor

MattFoley commented Nov 10, 2015

@nicklockwood, @sahrens, @a2 Correct me if I'm wrong, but the tests failing after my last commit/squash are not due to my code changes, correct?

@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne Nov 17, 2015

Collaborator

Cool :)

Collaborator

brentvatne commented Nov 17, 2015

Cool :)

@MattFoley MattFoley referenced this pull request in skillz/react-native Nov 18, 2015

Closed

adjustsFontSizeToFit implementation #7

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Nov 19, 2015

Contributor

Did something go wrong with the merge/rebase?

The adjustsFontSizeToFit and minimumFontScale are defined on both RCTText and RCTShadowText, but the ones on RCTShadowText aren't used anywhere in the code, and the ones on RCTText aren't exported in RCTTextManager.

Also, you don't seem to have added the new props to Text.js or TextStylePropTypes.js

Contributor

nicklockwood commented Nov 19, 2015

Did something go wrong with the merge/rebase?

The adjustsFontSizeToFit and minimumFontScale are defined on both RCTText and RCTShadowText, but the ones on RCTShadowText aren't used anywhere in the code, and the ones on RCTText aren't exported in RCTTextManager.

Also, you don't seem to have added the new props to Text.js or TextStylePropTypes.js

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 19, 2015

Contributor

I think that's just misunderstanding on my part, and the age of this PR. Let me remove them from RCTShadowText.

I was assuming that RCTTextManager just needed the two RCT_EXPORT_SHADOW_PROPERTY lines it has, is that not correct? Give me a bit and I will add them to Text.js and TextStylePropTypes.js.

Contributor

MattFoley commented Nov 19, 2015

I think that's just misunderstanding on my part, and the age of this PR. Let me remove them from RCTShadowText.

I was assuming that RCTTextManager just needed the two RCT_EXPORT_SHADOW_PROPERTY lines it has, is that not correct? Give me a bit and I will add them to Text.js and TextStylePropTypes.js.

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Nov 19, 2015

Contributor

RCT_EXPORT_SHADOW_PROPERTY exports properties on the shadow view. To export properties on the view you need RCT_EXPORT_VIEW_PROPERTY. I'm not sure how this could ever have worked in its current form.

Contributor

nicklockwood commented Nov 19, 2015

RCT_EXPORT_SHADOW_PROPERTY exports properties on the shadow view. To export properties on the view you need RCT_EXPORT_VIEW_PROPERTY. I'm not sure how this could ever have worked in its current form.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

Miracle of science I suppose.

Contributor

MattFoley commented Nov 20, 2015

Miracle of science I suppose.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

Are you sure that RCT_EXPORT_VIEW_PROPERTY is correct in this instance? It's not used for RCTText at all. (I said project originally, I meant the RCTText class and related.)

Contributor

MattFoley commented Nov 20, 2015

Are you sure that RCT_EXPORT_VIEW_PROPERTY is correct in this instance? It's not used for RCTText at all. (I said project originally, I meant the RCTText class and related.)

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

You know, I think I see part of what's missing. RCTText must be an odd case. From what I can tell, all properties of RCTText are exported as shadow properties, and then passed into RCTText from RCTShadowText via NSTextContainer, NSTextStorage, and NSLayoutManager. That being said, there were a few lines in RCTShadowText that have been squashed out. Updating now.

Contributor

MattFoley commented Nov 20, 2015

You know, I think I see part of what's missing. RCTText must be an odd case. From what I can tell, all properties of RCTText are exported as shadow properties, and then passed into RCTText from RCTShadowText via NSTextContainer, NSTextStorage, and NSLayoutManager. That being said, there were a few lines in RCTShadowText that have been squashed out. Updating now.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 20, 2015

@MattFoley updated the pull request.

@MattFoley updated the pull request.

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Nov 20, 2015

Contributor

@MattFoley thanks, that makes more sense. Is there any reason that this resizing logic can't be implemented on the shadow view though? It seems like it only relies on the view frame, which is calculated on the shadow side.

The reason we have this thread architecture is because calculating text layout is fairly expensive, so we do it off the main thread. But it seems like we lose the benefit of that if we then re-calculate it on the main thread in order to do the size adjustment.

Contributor

nicklockwood commented Nov 20, 2015

@MattFoley thanks, that makes more sense. Is there any reason that this resizing logic can't be implemented on the shadow view though? It seems like it only relies on the view frame, which is calculated on the shadow side.

The reason we have this thread architecture is because calculating text layout is fairly expensive, so we do it off the main thread. But it seems like we lose the benefit of that if we then re-calculate it on the main thread in order to do the size adjustment.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

That makes sense. I think I'm mainly doing it on the main thread now so that I knew the font was only modified after the frame was completely set for the view. I'm trying to move it out to the RCTextShadowView now without much luck yet.

Contributor

MattFoley commented Nov 20, 2015

That makes sense. I think I'm mainly doing it on the main thread now so that I knew the font was only modified after the frame was completely set for the view. I'm trying to move it out to the RCTextShadowView now without much luck yet.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

Ah, immediately after typing that I figured out what I was doing wrong. Give me a bit and I'll have this cleaned up and moved out to RCTShadowText.

Contributor

MattFoley commented Nov 20, 2015

Ah, immediately after typing that I figured out what I was doing wrong. Give me a bit and I'll have this cleaned up and moved out to RCTShadowText.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 20, 2015

@MattFoley updated the pull request.

@MattFoley updated the pull request.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 20, 2015

@MattFoley updated the pull request.

@MattFoley updated the pull request.

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Nov 20, 2015

Contributor

This looks great, thanks!

@facebook-github-bot import

Contributor

nicklockwood commented Nov 20, 2015

This looks great, thanks!

@facebook-github-bot import

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

I'm going to run some more in depth tests on this @nicklockwood with some of my own projects that are using this, just to make sure everything is solid on master. But yay! 🎉

Contributor

MattFoley commented Nov 20, 2015

I'm going to run some more in depth tests on this @nicklockwood with some of my own projects that are using this, just to make sure everything is solid on master. But yay! 🎉

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Nov 20, 2015

Contributor

It would be great if you could add an example to the TextExample.hs in UIExplorer that demos the feature.

Contributor

nicklockwood commented Nov 20, 2015

It would be great if you could add an example to the TextExample.hs in UIExplorer that demos the feature.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Nov 20, 2015

Contributor

Yeah, I will, may be a few days. After these changes, I'm having trouble running against this with some of my older projects using this stuff, so I'd like to take a little while to make sure this is working the way it should. (Probably has something to do with my build environment.) Wait on this PR until there's a working example?

Contributor

MattFoley commented Nov 20, 2015

Yeah, I will, may be a few days. After these changes, I'm having trouble running against this with some of my older projects using this stuff, so I'd like to take a little while to make sure this is working the way it should. (Probably has something to do with my build environment.) Wait on this PR until there's a working example?

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 20, 2015

@MattFoley updated the pull request.

@MattFoley updated the pull request.

@GantMan

This comment has been minimized.

Show comment
Hide comment
@GantMan

GantMan Dec 11, 2015

Contributor

👍 hope to see this feature soon. Great work!

Contributor

GantMan commented Dec 11, 2015

👍 hope to see this feature soon. Great work!

@marcshilling

This comment has been minimized.

Show comment
Hide comment
@marcshilling

marcshilling Dec 29, 2015

I cherry-picked this and have been using it in my app. Pretty great! The only thing is I wish it would append '...' if your minimumFontScale was not small enough to fit the whole string. Think that could be accomplished?

I cherry-picked this and have been using it in my app. Pretty great! The only thing is I wish it would append '...' if your minimumFontScale was not small enough to fit the whole string. Think that could be accomplished?

@marcshilling

This comment has been minimized.

Show comment
Hide comment
@marcshilling

marcshilling Dec 30, 2015

@MattFoley hmmm, I'm running into some issues with this today. It appears that text isn't always re-rendering.

I'm logging a variable name in my render method, and using it inside a <Text> component. On the initial render, name is an empty string, but eventually new props come in and it becomes a valid string. Re-render is triggered (I see name logged correctly), but the <Text> remains blank.

Any idea what could be going on?

Edit: it's not just with the text either, it appears to also be effecting styles...i.e. opacity is not re-rendering correctly

@MattFoley hmmm, I'm running into some issues with this today. It appears that text isn't always re-rendering.

I'm logging a variable name in my render method, and using it inside a <Text> component. On the initial render, name is an empty string, but eventually new props come in and it becomes a valid string. Re-render is triggered (I see name logged correctly), but the <Text> remains blank.

Any idea what could be going on?

Edit: it's not just with the text either, it appears to also be effecting styles...i.e. opacity is not re-rendering correctly

@skevy

This comment has been minimized.

Show comment
Hide comment
@skevy

skevy Jan 6, 2016

Collaborator

@MattFoley just wanted to ping on this...any news on this PR?

Collaborator

skevy commented Jan 6, 2016

@MattFoley just wanted to ping on this...any news on this PR?

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Jan 6, 2016

Contributor

Still haven't had time to build an example for this. @marcshilling Were you able to fix the issues you found with this? or for the ...? I haven't had a chance to look into either yet. I'm doing a few similar things (fetching strings from the native code, storing those values in my component state and updating them there to trigger a re-render. It works for me, but I'm on v0.11 still)

Contributor

MattFoley commented Jan 6, 2016

Still haven't had time to build an example for this. @marcshilling Were you able to fix the issues you found with this? or for the ...? I haven't had a chance to look into either yet. I'm doing a few similar things (fetching strings from the native code, storing those values in my component state and updating them there to trigger a re-render. It works for me, but I'm on v0.11 still)

@marcshilling

This comment has been minimized.

Show comment
Hide comment
@marcshilling

marcshilling Jan 6, 2016

@MattFoley I have not. The ellipses thing is more of a nice to have feature, but the text not re-rendering is definitely a bug that needs to be fixed. I wouldn't really know where to start...but if it would help I could try to put together an example project that displays it breaking?

@MattFoley I have not. The ellipses thing is more of a nice to have feature, but the text not re-rendering is definitely a bug that needs to be fixed. I wouldn't really know where to start...but if it would help I could try to put together an example project that displays it breaking?

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Jul 29, 2016

Contributor

@marcshilling Looks like you've been reviewing and merging in ObjC PRs. Feel good about merging this one in? I've just been bumping this PR and rebasing since June, it feels good to merge to me.

Contributor

MattFoley commented Jul 29, 2016

@marcshilling Looks like you've been reviewing and merging in ObjC PRs. Feel good about merging this one in? I've just been bumping this PR and rebasing since June, it feels good to merge to me.

@ghost ghost added the CLA Signed label Jul 29, 2016

@marcshilling

This comment has been minimized.

Show comment
Hide comment
@marcshilling

marcshilling Jul 29, 2016

@MattFoley not me - I don't have merge permissions! I would if I could!

@MattFoley not me - I don't have merge permissions! I would if I could!

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Jul 29, 2016

Contributor

@marcshilling Thanks Marc, is there anyone else I can poke about this?

Contributor

MattFoley commented Jul 29, 2016

@marcshilling Thanks Marc, is there anyone else I can poke about this?

@ghost ghost added the CLA Signed label Jul 29, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 8, 2016

@MattFoley updated the pull request.

ghost commented Aug 8, 2016

@MattFoley updated the pull request.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Aug 8, 2016

Contributor

Just cleaning up what I think the last thing ESLint bot was complaining about.

Contributor

MattFoley commented Aug 8, 2016

Just cleaning up what I think the last thing ESLint bot was complaining about.

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Aug 8, 2016

Contributor

Rebased on top of master again.

Contributor

MattFoley commented Aug 8, 2016

Rebased on top of master again.

@ghost ghost added the CLA Signed label Aug 8, 2016

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Aug 8, 2016

Contributor

@mkonicek @majak I hate to keep pinging you guys on this, but I'd really like to get this merged in before I do another RN update. Is there anything I can do to help move this along? Thanks!

Contributor

MattFoley commented Aug 8, 2016

@mkonicek @majak I hate to keep pinging you guys on this, but I'd really like to get this merged in before I do another RN update. Is there anything I can do to help move this along? Thanks!

@ghost ghost added the CLA Signed label Aug 8, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 8, 2016

@MattFoley updated the pull request.

ghost commented Aug 8, 2016

@MattFoley updated the pull request.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 8, 2016

@MattFoley updated the pull request.

ghost commented Aug 8, 2016

@MattFoley updated the pull request.

Initial implementation of adjustsFontSizeToFit.
added @platform iOS

Building UIExplorer Example, adding back in height error margin requirement, and add in RCTMeasure call.
@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Aug 8, 2016

Contributor

Note, I had to update this PR to fix a failing test due to a previous rebase.

Contributor

MattFoley commented Aug 8, 2016

Note, I had to update this PR to fix a failing test due to a previous rebase.

@ghost ghost added the CLA Signed label Aug 9, 2016

@skevy

This comment has been minimized.

Show comment
Hide comment
Collaborator

skevy commented Aug 10, 2016

@skevy

This comment has been minimized.

Show comment
Hide comment
@skevy

skevy Aug 10, 2016

Collaborator

@MattFoley thank you SO much for sticking with this for so long. Sorry it took so long to get it merged!

Collaborator

skevy commented Aug 10, 2016

@MattFoley thank you SO much for sticking with this for so long. Sorry it took so long to get it merged!

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 10, 2016

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

ghost commented Aug 10, 2016

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed label Aug 10, 2016

@marcshilling

This comment has been minimized.

Show comment
Hide comment

@skevy @MattFoley 👏👏👏👏

@ghost ghost closed this in c6b6f53 Aug 10, 2016

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Aug 10, 2016

Contributor

@skevy Thanks!!!!!!!!!!!!!!!!!!!!!!!!

ps. @brentvatne it happened. 🎉

Contributor

MattFoley commented Aug 10, 2016

@skevy Thanks!!!!!!!!!!!!!!!!!!!!!!!!

ps. @brentvatne it happened. 🎉

@collinglass

This comment has been minimized.

Show comment
Hide comment
@collinglass

collinglass Aug 11, 2016

👏👏👏

👏👏👏

cmcewen added a commit to cmcewen/react-native that referenced this pull request Aug 15, 2016

Initial implementation of adjustsFontSizeToFit.
Summary: Closes facebook#4026

Differential Revision: D2678492

Pulled By: nicklockwood

fbshipit-source-id: 0467814f810fee997ac50960ffb1daa74d52acba

mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016

Initial implementation of adjustsFontSizeToFit.
Summary: Closes facebook#4026

Differential Revision: D2678492

Pulled By: nicklockwood

fbshipit-source-id: 0467814f810fee997ac50960ffb1daa74d52acba

rozele pushed a commit to Microsoft/react-native-windows that referenced this pull request Aug 25, 2016

Initial implementation of adjustsFontSizeToFit.
Summary: Closes facebook/react-native#4026

Differential Revision: D2678492

Pulled By: nicklockwood

fbshipit-source-id: 0467814f810fee997ac50960ffb1daa74d52acba
@chandlervdw

This comment has been minimized.

Show comment
Hide comment
@chandlervdw

chandlervdw Sep 2, 2016

@MattFoley so, is this available in react-native@0.32 or no? Thanks so much for this!

@MattFoley so, is this available in react-native@0.32 or no? Thanks so much for this!

@MattFoley

This comment has been minimized.

Show comment
Hide comment
@MattFoley

MattFoley Sep 2, 2016

Contributor

It's in .33rc I think, you're welcome!

Sent from my iPhone

On Sep 2, 2016, at 7:58 AM, Chandler Van De Water notifications@github.com wrote:

@MattFoley so, is this available in react-native@0.32 or no? Thanks so much for this!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

MattFoley commented Sep 2, 2016

It's in .33rc I think, you're welcome!

Sent from my iPhone

On Sep 2, 2016, at 7:58 AM, Chandler Van De Water notifications@github.com wrote:

@MattFoley so, is this available in react-native@0.32 or no? Thanks so much for this!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@pyankoff

This comment has been minimized.

Show comment
Hide comment
@pyankoff

pyankoff Oct 25, 2016

Text gets truncated a little bit (maybe because of large font?). Easily solved by adding style={{marginVertical: 6}} tho.

Text gets truncated a little bit (maybe because of large font?). Easily solved by adding style={{marginVertical: 6}} tho.

@jasan-s

This comment has been minimized.

Show comment
Hide comment
@jasan-s

jasan-s Jun 14, 2017

can adjustsFontSizeToFit work with TextInput? On the user input

jasan-s commented Jun 14, 2017

can adjustsFontSizeToFit work with TextInput? On the user input

@garrettmac

This comment has been minimized.

Show comment
Hide comment
@garrettmac

garrettmac Jul 19, 2017

You can add adjustsFontSizeToFit={true} (currently undocumented) to you Text Component to auto adjust the size inside a parent node.

  <Text adjustsFontSizeToFit={true} numberOfLines={1}>Hiiiz</Text>

You can also add the following in your Text Component:

<Text style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>

Or you can add the following into the parent of the Text component:

<View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text>Hiiiz</Text>
</View>

or both

 <View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>
</View>

or all three

 <View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text adjustsFontSizeToFit={true} 
           numberOfLines={1} 
           style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>
</View>

before
screen shot 2017-07-19 at 9 48 05 am

after

screen shot 2017-07-19 at 9 47 34 am

It all depends on what you're doing. You can also checkout my full blog post on the topic

https://medium.com/@vygaio/how-to-auto-adjust-text-font-size-to-fit-into-a-nodes-width-in-react-native-9f7d1d68305b

You can add adjustsFontSizeToFit={true} (currently undocumented) to you Text Component to auto adjust the size inside a parent node.

  <Text adjustsFontSizeToFit={true} numberOfLines={1}>Hiiiz</Text>

You can also add the following in your Text Component:

<Text style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>

Or you can add the following into the parent of the Text component:

<View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text>Hiiiz</Text>
</View>

or both

 <View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>
</View>

or all three

 <View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text adjustsFontSizeToFit={true} 
           numberOfLines={1} 
           style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>
</View>

before
screen shot 2017-07-19 at 9 48 05 am

after

screen shot 2017-07-19 at 9 47 34 am

It all depends on what you're doing. You can also checkout my full blog post on the topic

https://medium.com/@vygaio/how-to-auto-adjust-text-font-size-to-fit-into-a-nodes-width-in-react-native-9f7d1d68305b

@mkozhukharenko

This comment has been minimized.

Show comment
Hide comment
@mkozhukharenko

mkozhukharenko Sep 22, 2017

it does not work for Android in react 47.1 and does not work perfectly for IOS

it does not work for Android in react 47.1 and does not work perfectly for IOS

@AfiyaA

This comment has been minimized.

Show comment
Hide comment
@AfiyaA

AfiyaA Nov 20, 2017

Does this work for Android? It works for me for IOS but need Android support as well.

AfiyaA commented Nov 20, 2017

Does this work for Android? It works for me for IOS but need Android support as well.

@skv-headless

This comment has been minimized.

Show comment
Hide comment
@skv-headless

skv-headless Feb 9, 2018

Contributor

I should be doable for android https://react-native.canny.io/feature-requests/p/textandroid-autosizing-support. But I failed to implement it maybe someone more experienced with react-native can do it.

Contributor

skv-headless commented Feb 9, 2018

I should be doable for android https://react-native.canny.io/feature-requests/p/textandroid-autosizing-support. But I failed to implement it maybe someone more experienced with react-native can do it.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment