refactor: use same rectangle spec for DebuggingOverlay native commands#41742
Closed
hoxyq wants to merge 5 commits into
Closed
refactor: use same rectangle spec for DebuggingOverlay native commands#41742hoxyq wants to merge 5 commits into
hoxyq wants to merge 5 commits into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708055 |
Base commit: af8c56a |
1800472 to
887c4e4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708055 |
887c4e4 to
07242d8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708055 |
07242d8 to
d122f88
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708055 |
d122f88 to
8fea257
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708055 |
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods. For some methods actual implementation will be published in the next diffs. Differential Revision: https://internalfb.com/D51536787 fbshipit-source-id: 0d7b40fd0cb043d079eea0f0850f51ffe51b5de6
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603860 fbshipit-source-id: 004f109eab03c947725ea0095acd3e7e0fdfd3de
…ents Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603861 fbshipit-source-id: 2467caabb53bba39ff1e2c546ef9bdbce9aa4eac
…vTools Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51708053 fbshipit-source-id: b7b41c2f7cff4247118722e23f78f8d8d1bbacf7
react#41742) Summary: Pull Request resolved: react#41742 Changelog: [Internal] TSIA Differential Revision: D51708055 fbshipit-source-id: b37e1f9668e1bf464b6cc176e79112353d9b9598
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708055 |
8fea257 to
cda68bb
Compare
Contributor
|
This pull request has been merged in 128ff50. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
TSIA
Differential Revision: D51708055