Skip to content

refactor: use same rectangle spec for DebuggingOverlay native commands#41742

Closed
hoxyq wants to merge 5 commits into
react:mainfrom
hoxyq:export-D51708055
Closed

refactor: use same rectangle spec for DebuggingOverlay native commands#41742
hoxyq wants to merge 5 commits into
react:mainfrom
hoxyq:export-D51708055

Conversation

@hoxyq

@hoxyq hoxyq commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Summary:
Changelog: [Internal]

TSIA

Differential Revision: D51708055

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 1, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51708055

@analysis-bot

analysis-bot commented Dec 1, 2023

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,582,044 +4,090
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,035 -7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: af8c56a
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51708055

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51708055

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51708055

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51708055

Ruslan Lesiutin and others added 5 commits January 2, 2024 04:15
Summary:
Changelog: [Internal]

There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component.

It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods.

For some methods actual implementation will be published in the next diffs.

Differential Revision: https://internalfb.com/D51536787

fbshipit-source-id: 0d7b40fd0cb043d079eea0f0850f51ffe51b5de6
Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51603860

fbshipit-source-id: 004f109eab03c947725ea0095acd3e7e0fdfd3de
…ents

Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51603861

fbshipit-source-id: 2467caabb53bba39ff1e2c546ef9bdbce9aa4eac
…vTools

Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51708053

fbshipit-source-id: b7b41c2f7cff4247118722e23f78f8d8d1bbacf7
react#41742)

Summary:
Pull Request resolved: react#41742

Changelog: [Internal]

TSIA

Differential Revision: D51708055

fbshipit-source-id: b37e1f9668e1bf464b6cc176e79112353d9b9598
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51708055

@hoxyq hoxyq force-pushed the export-D51708055 branch from 8fea257 to cda68bb Compare January 2, 2024 12:18
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 15, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 128ff50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants