refactor: DebuggingRegistry to handle native highlights from React DevTools#41746
Closed
hoxyq wants to merge 4 commits into
Closed
refactor: DebuggingRegistry to handle native highlights from React DevTools#41746hoxyq wants to merge 4 commits into
hoxyq wants to merge 4 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
Base commit: af8c56a |
hoxyq
force-pushed
the
export-D51708053
branch
from
02e9e7a to
b4ed6a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
b4ed6a7 to
b2362e9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
b2362e9 to
ba56187
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
ba56187 to
281d926
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to inspected views (ancestors) as subscriptions and later will call all necessary methods. For some methods actual implementation will be published in the next diffs. Differential Revision: https://internalfb.com/D51536787 fbshipit-source-id: d0ee320c35f003901b9f1e46619970c4a51c6fd1
Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603860 fbshipit-source-id: 0c517c57e14693a30348fe11880a4ebaa30be121
…ents Summary: Changelog: [Internal] Differential Revision: https://internalfb.com/D51603861 fbshipit-source-id: 8ad27736735f3ea2c33dc6d5f015fb17b9cc99cb
…vTools (react#41746) Summary: Pull Request resolved: react#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 fbshipit-source-id: 64004323fb5120e81243764f7ce5a67e01221ed1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51708053 |
hoxyq
force-pushed
the
export-D51708053
branch
from
281d926 to
2e1d543
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…eact DevTools (react#41746) Summary: Pull Request resolved: react#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: a6b79f79532602babbff9f484f506170492aed57
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…eact DevTools (react#41746) Summary: Pull Request resolved: react#41746 Changelog: [Internal] Now using previously added `highlightElements` and `clearElementsHighlights` commands. [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times. All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental. Differential Revision: D51708053 Reviewed By: sammy-SC fbshipit-source-id: 97f85f7b236602da9bc1b7bacf6c347ce67faec8
Contributor
|
This pull request has been merged in 1b9310e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Now using previously added
highlightElementsandclearElementsHighlightscommands.[Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not number-of-rendered-AppContainers times.
All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.
Differential Revision: D51708053