From 7a70844d50079848ed48e40ea0e27bab00e0e797 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 21 Dec 2023 15:21:13 -0800 Subject: [PATCH] Rename prefix of binaryCompatibilityValidator properties (#42041) Summary: binaryCompatibilityValidator is a generic library, it shouldn't have referecences to react. I'm renaming: ``` react.internal.binaryCompatibilityValidator... ``` by ``` binaryCompatibilityValidator... ``` changelog: [internal] internal Reviewed By: philIip Differential Revision: D52380035 --- build.gradle.kts | 9 ++++----- packages/react-native/ReactAndroid/gradle.properties | 10 +++++----- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index de043f8d8bb7..9bee6febbc05 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -24,14 +24,13 @@ fun getListReactAndroidProperty(name: String) = reactAndroidProperties.getProper apiValidation { ignoredPackages.addAll( - getListReactAndroidProperty("react.internal.binaryCompatibilityValidator.ignoredPackages")) - ignoredClasses.addAll( - getListReactAndroidProperty("react.internal.binaryCompatibilityValidator.ignoredClasses")) + getListReactAndroidProperty("binaryCompatibilityValidator.ignoredPackages")) + ignoredClasses.addAll(getListReactAndroidProperty("binaryCompatibilityValidator.ignoredClasses")) nonPublicMarkers.addAll( - getListReactAndroidProperty("react.internal.binaryCompatibilityValidator.nonPublicMarkers")) + getListReactAndroidProperty("binaryCompatibilityValidator.nonPublicMarkers")) validationDisabled = reactAndroidProperties - .getProperty("react.internal.binaryCompatibilityValidator.validationDisabled") + .getProperty("binaryCompatibilityValidator.validationDisabled") ?.toBoolean() == true } diff --git a/packages/react-native/ReactAndroid/gradle.properties b/packages/react-native/ReactAndroid/gradle.properties index 447d1963ee29..c648a004285b 100644 --- a/packages/react-native/ReactAndroid/gradle.properties +++ b/packages/react-native/ReactAndroid/gradle.properties @@ -9,8 +9,8 @@ android.enableJetifier=true react.internal.disableJavaVersionAlignment=true # Binary Compatibility Validator properties -react.internal.binaryCompatibilityValidator.ignoredClasses=com.facebook.react.BuildConfig -react.internal.binaryCompatibilityValidator.ignoredPackages=com.facebook.debug,\ +binaryCompatibilityValidator.ignoredClasses=com.facebook.react.BuildConfig +binaryCompatibilityValidator.ignoredPackages=com.facebook.debug,\ com.facebook.fbreact,\ com.facebook.hermes,\ com.facebook.perftest,\ @@ -22,7 +22,7 @@ react.internal.binaryCompatibilityValidator.ignoredPackages=com.facebook.debug,\ com.facebook.react.processing,\ com.facebook.systrace,\ com.facebook.yoga -react.internal.binaryCompatibilityValidator.nonPublicMarkers=com.facebook.react.common.annotations.VisibleForTesting,\ +binaryCompatibilityValidator.nonPublicMarkers=com.facebook.react.common.annotations.VisibleForTesting,\ com.facebook.react.common.annotations.UnstableReactNativeAPI -react.internal.binaryCompatibilityValidator.validationDisabled=true -react.internal.binaryCompatibilityValidator.outputApiFileName=ReactAndroid +binaryCompatibilityValidator.validationDisabled=true +binaryCompatibilityValidator.outputApiFileName=ReactAndroid