(iOS) Add RCTUIStatusBarManager and properly retrieve StatusBar style and height#42241
Closed
okwasniewski wants to merge 3 commits into
Closed
(iOS) Add RCTUIStatusBarManager and properly retrieve StatusBar style and height#42241okwasniewski wants to merge 3 commits into
RCTUIStatusBarManager and properly retrieve StatusBar style and height#42241okwasniewski wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Base commit: cf4963f |
cipolleschi
approved these changes
Jan 12, 2024
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
I am not sure we can blidnly remove the getHeight methods. We might have components/apps that uses them internally.
I'll import and let our CI test them for us.
A part from that, it looks good.
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Thanks! Let me know if I should bring it back |
Contributor
|
@cipolleschi merged this pull request in 3dfedbc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR migrates from the deprecated way of retrieving the status bar info. It introduces a helper method
RCTUIStatusBarManagerwhich gets theUIStatusBarManagerfrom the KeyWindow.It also removes the unused
getHeightmethod.Changelog:
[IOS] [ADDED] - Add
RCTUIStatusBarManagerand properly retrieve StatusBar style and height[IOS] [REMOVED] - Remove unused getHeight method from StatusBar
Test Plan:
CI Green, Ensure that preferredStatusBarStyle and preferredStatusBarHidden is properly retrieved for Modals