Skip to content

[RN] Move flags unused in OSS from legacy ReactNativeFeatureFlags (JS) to the new system#42433

Closed
rubennorte wants to merge 1 commit into
react:mainfrom
rubennorte:export-D52905703
Closed

[RN] Move flags unused in OSS from legacy ReactNativeFeatureFlags (JS) to the new system#42433
rubennorte wants to merge 1 commit into
react:mainfrom
rubennorte:export-D52905703

Conversation

@rubennorte

@rubennorte rubennorte commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

Summary: Changelog: [internal]

Differential Revision: D52905703

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 20, 2024
@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@rubennorte @facebook-github-bot
Move flags unused in OSS from legacy ReactNativeFeatureFlags (JS) to …
04b3a1f 
…the new system (react#42433)

Summary:

Changelog: [internal]

The only flags we know are being [assigned](https://github.com/search?type=code&q=%2FReactNativeFeatureFlags%5C.%5Cw%2B+%3D%2F+lang%3AJavaScript+NOT+path%3AReactNative%2FReactNativeFeatureFlags.js+NOT+path%3Apackages%2Freact-native+NOT+is%3Afork) in OSS are:
* `shouldEmitW3CPointerEvents`
* `shouldPressibilityUseW3CPointerEventsForHover`

So we can migrate all the rest relatively safely.

Reviewed By: javache

Differential Revision: D52905703
@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52905703

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request has been merged in 2108269.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte @facebook-github-bot @analysis-bot