Skip to content

react-native: Bridging. Add conversion functions to std::array<T, N> and std::pair<T1, T2>#42558

Closed
christophpurrer wants to merge 1 commit into
react:mainfrom
christophpurrer:export-D52943602
Closed

react-native: Bridging. Add conversion functions to std::array<T, N> and std::pair<T1, T2>#42558
christophpurrer wants to merge 1 commit into
react:mainfrom
christophpurrer:export-D52943602

Conversation

@christophpurrer

@christophpurrer christophpurrer commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

Summary:
Changelog: [Internal]

These are currently missing.
They are convinient to e.g. turn an array of JS arrays such as [["key", "value"]] into a

  • std::vector<std::array<T, N>> or
  • std::vector<std::pair<T1, T2>>

Differential Revision: D52943602

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2024
@facebook-github-bot

facebook-github-bot commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@analysis-bot

analysis-bot commented Jan 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,945,176 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,332,486 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 94c72d5
Branch: main

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@christophpurrer @facebook-github-bot
react-native: Bridging. Add conversion functions to std::array<T, N> …
cb8d124 
…and std::pair<T1, T2> (react#42558)

Summary:

Changelog: [Internal]

These are currently missing.

They are convinient to e.g. turn an array of JS arrays such as `[["key", "value"]]` into a
- std::vector<std::array<T, N>> or
- std::vector<std::pair<T1, T2>>

which is e.g. used here: https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Network/RCTNetworking.android.js#L25-L31

Reviewed By: javache

Differential Revision: D52943602
@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52943602

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 22, 2024
@facebook-github-bot

facebook-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This pull request has been merged in 4681e40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christophpurrer @facebook-github-bot @analysis-bot