Remove dependency on PropsParserContext#42616
Conversation
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
Base commit: 3869ae4 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
7b4b51c to
3e941ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
3e941ad to
8deab5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
8deab5c to
b726213
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
b726213 to
14044a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
14044a1 to
8dfe5d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
8dfe5d5 to
2f5683a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
2f5683a to
0b91bf0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
0b91bf0 to
4bd44fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
cipolleschi
force-pushed
the
export-D52999204
branch
from
4bd44fe to
260dc3f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
Summary: PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the `surfaceId` and the `contextContainer`. We don't need to bring to graphics the whole dependencies of core due to these two parts. This change break the dependency by passing along only the elements that we actually need. ## Changelog [Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext Reviewed By: sammy-SC Differential Revision: D52999204
cipolleschi
force-pushed
the
export-D52999204
branch
from
260dc3f to
bc40417
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52999204 |
|
This pull request has been merged in 5bf5f4b. |
3 participants
Summary:
PropsParserContext is an entity in Core with a lot of baggage. We used it in graphics only to access the
surfaceIdand thecontextContainer. We don't need to bring to graphics the whole dependencies of core due to these two parts.This change break the dependency by passing along only the elements that we actually need.
Changelog
[Internal] - break dependencies between graphics and core by removing the include of the PropsParserContext
Differential Revision: D52999204