Skip to content

Remove RCTAppSetupPrepareApp overload and InspectorFlags call#42642

Closed
huntie wants to merge 1 commit into
facebook:mainfrom
huntie:export-D53048207
Closed

Remove RCTAppSetupPrepareApp overload and InspectorFlags call#42642
huntie wants to merge 1 commit into
facebook:mainfrom
huntie:export-D53048207

Conversation

@huntie

@huntie huntie commented Jan 24, 2024

Copy link
Copy Markdown
Member

Summary:
Removes call to InspectorFlags::initFromConfig, since this approach is being replaced with ReactNativeFeatureFlags. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - Un-deprecates RCTAppSetupPrepareApp (reverts #41976)

Differential Revision: D53048207

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 24, 2024
@facebook-github-bot

facebook-github-bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@analysis-bot

analysis-bot commented Jan 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,270 -14
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,096 -15
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: db066ac
Branch: main

okwasniewski
okwasniewski reviewed Jan 25, 2024
View reviewed changes
Comment thread packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm Outdated

@okwasniewski okwasniewski Jan 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! This will make my PR easier #42263 (no need to separate this logic to another function). Commenting here to get notified when it gets merged 👍🏻

@huntie huntie Jan 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :D It'll get merged as soon as I sort out the PR that's stacked with this (failing internal CI in a tricky way).

@facebook-github-bot

facebook-github-bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

1 similar comment
@facebook-github-bot

facebook-github-bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot

facebook-github-bot commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot

facebook-github-bot commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot

facebook-github-bot commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot

facebook-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot

facebook-github-bot commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot

facebook-github-bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@huntie @facebook-github-bot
Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…
b73a9e6 
…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Reviewed By: motiz88

Differential Revision: D53048207
@facebook-github-bot

facebook-github-bot commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53048207

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 13, 2024
@facebook-github-bot

facebook-github-bot commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

This pull request has been merged in ce3ce11.

@huntie huntie deleted the export-D53048207 branch February 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@okwasniewski okwasniewski okwasniewski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huntie @facebook-github-bot @analysis-bot @okwasniewski