Fixup bad ANDROIDLINT Automatic Fix#42694
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53158801 |
Base commit: 5d559c1 |
Summary: D53115471 commited all the automatically fixable lints by `ANDROIDLINT`. When I looked again, closer, there was one automatic fix that I'm fairly sure is incorrect. Before: `outTransform.postTranslate((int) (dx + 0.5f), (int) (dy + 0.5f));` After: `outTransform.postTranslate((dx + 0.5f), (dy + 0.5f));` I think the linter did this because the underlying API accepts a float, so this was (incorrectly) seen as an extraneous cast causing precision loss, but the previous behavior was using the cast and addition to round the float, instead of adding 0.5 to it. This replaces the call with an explicit rounding, for the same behavior as before (though, I'm not sure if the rounding is intentional, since in and out are both fp). Changelog: [Internal] Reviewed By: joevilches Differential Revision: D53158801
NickGerleman
force-pushed
the
export-D53158801
branch
from
328cdac to
65e4630
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53158801 |
Contributor
|
This pull request has been merged in 3a789a1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D53115471 commited all the automatically fixable lints by
ANDROIDLINT. When I looked again, closer, there was one automatic fix that I'm fairly sure is incorrect.Before:
outTransform.postTranslate((int) (dx + 0.5f), (int) (dy + 0.5f));After:
outTransform.postTranslate((dx + 0.5f), (dy + 0.5f));I think the linter did this because the underlying API accepts a float, so this was (incorrectly) seen as an extraneous cast causing precision loss, but the previous behavior was using the cast and addition to round the float, instead of adding 0.5 to it.
This replaces the call with an explicit rounding, for the same behavior as before (though, I'm not sure if the rounding is intentional, since in and out are both fp).
Changelog: [Internal]
Differential Revision: D53158801