Fix broken ReactNativeFeatureFlagsTest test on iOS#42699
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53178474 |
Base commit: cfc0ba0 |
rubennorte
force-pushed
the
export-D53178474
branch
from
b00977c to
379c3da
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53178474 |
rubennorte
force-pushed
the
export-D53178474
branch
from
379c3da to
285a582
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53178474 |
Summary: Changelog: [internal] The test was fine on C++. The reason is probably that C++ destroys the process between tests (effectively resetting singletons) while iOS doesn't. This fixes the test by implementing a correct `TearDown` method to reset the flags. Reviewed By: rshest Differential Revision: D53178474
rubennorte
force-pushed
the
export-D53178474
branch
from
285a582 to
9d7a126
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53178474 |
Contributor
|
This pull request has been merged in 9ef6d60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The test was fine on C++. The reason is probably that C++ destroys the process between tests (effectively resetting singletons) while iOS doesn't.
This fixes the test by implementing a correct
TearDownmethod to reset the flags.Differential Revision: D53178474