Refactor RCT_handleKeyCommand to avoid concurrency issues#42708
Closed
cipolleschi wants to merge 1 commit into
Closed
Refactor RCT_handleKeyCommand to avoid concurrency issues#42708cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53186262 |
cipolleschi
force-pushed
the
export-D53186262
branch
from
d20193a to
6037725
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53186262 |
cipolleschi
force-pushed
the
export-D53186262
branch
from
6037725 to
341e2ca
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53186262 |
cipolleschi
force-pushed
the
export-D53186262
branch
from
341e2ca to
e846603
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53186262 |
Summary: When pressing `r` on simulator in Bridgeless mode, we have a race condition between: - RCTKeyCommands evaluating the blocks to be invoked - ReactNative invalidating the DevMenu with the list of RCTKeyCommands (on which ReactNative is iterating). The fix checks which commands need to be executed, stores them in an array and then iterates on the array, which is local to the function call, avoiding any concurrency issue. ## Changelog: [iOS][Fixed] - Refactored RCT_handleKeyCommand to avoid concurrency issues Reviewed By: motiz88 Differential Revision: D53186262
cipolleschi
force-pushed
the
export-D53186262
branch
from
e846603 to
5add77d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53186262 |
Contributor
|
This pull request has been merged in 8d710bf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When pressing
ron simulator in Bridgeless mode, we have a race condition between:The fix checks which commands need to be executed, stores them in an array and then iterates on the array, which is local to the function call, avoiding any concurrency issue.
Changelog:
[iOS][Fixed] - Refactored RCT_handleKeyCommand to avoid concurrency issues
Reviewed By: motiz88
Differential Revision: D53186262