Migrate enableSpannableBuildingUnification to new feature flag system#42716
Closed
NickGerleman wants to merge 1 commit into
Closed
Migrate enableSpannableBuildingUnification to new feature flag system#42716NickGerleman wants to merge 1 commit into
enableSpannableBuildingUnification to new feature flag system#42716NickGerleman wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53198874 |
NickGerleman
force-pushed
the
export-D53198874
branch
from
6a1ff96 to
ec63ca5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53198874 |
Base commit: 3a789a1 |
…em (facebook#42716) Summary: Migrates this to the new flag system just added. Made a quick change to the Android template, to mark Kotlin accessors as `JvmStatic` to make calling from Java more idiomatic. Next diff will wire to MC. Changelog: [Internal] Reviewed By: rubennorte, mdvacca Differential Revision: D53198874
NickGerleman
force-pushed
the
export-D53198874
branch
from
ec63ca5 to
d08c467
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53198874 |
Contributor
|
This pull request has been merged in daa3080. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates this to the new flag system just added.
Made a quick change to the Android template, to mark Kotlin accessors as
JvmStaticto make calling from Java more idiomatic.Next diff will wire to MC.
Changelog: [Internal]
Reviewed By: rubennorte, mdvacca
Differential Revision: D53198874