Skip to content

'[skip ci] [RN][Android] Fix wrong type in kotlin#42726

Closed
mdvacca wants to merge 1 commit into
react:mainfrom
mdvacca:export-D53200101
Closed

'[skip ci] [RN][Android] Fix wrong type in kotlin#42726
mdvacca wants to merge 1 commit into
react:mainfrom
mdvacca:export-D53200101

Conversation

@mdvacca

@mdvacca mdvacca commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Summary:
initHybrid always return a HybridData. we shouldn'''t allow null here.

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D53200101

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 30, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53200101

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53200101

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53200101

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,181,006 +2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,559,917 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2f818b4
Branch: main

Summary:

initHybrid always return a HybridData. we shouldn't allow null here.

changelog: [internal] internal

Reviewed By: cortinico, NickGerleman

Differential Revision: D53200101
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53200101

mdvacca added a commit to mdvacca/react-native that referenced this pull request Jan 31, 2024
Summary:

initHybrid always return a HybridData. we shouldn't allow null here.

changelog: [internal] internal

Reviewed By: cortinico, NickGerleman

Differential Revision: D53200101
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 31, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 6cae417.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants