[Fabric] Fixes semantic color not work when dark mode changed#42737
Closed
zhongwuzw wants to merge 1 commit into
Closed
[Fabric] Fixes semantic color not work when dark mode changed#42737zhongwuzw wants to merge 1 commit into
zhongwuzw wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Jan 30, 2024
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me. You know that, in the simulator, you can use ⌘+⇧+A to switch between light and dark mode? 😄
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-30.at.15.09.15.mp4
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: e97ba47 |
Contributor
|
@cipolleschi merged this pull request in 3d71b11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When we changed dark mode, the semantic color was not applied because we use color components, it's not dynamic. So let's store the
UIColorfor semantic color directly.Simulator.Screen.Recording.-.iPhone.15.-.2024-01-30.at.22.56.58.mp4
Changelog:
[IOS] [FIXED] - [Fabric] Fixes semantic color not work when dark mode changed
Test Plan:
semantic color changed when switch dark mode.