Reduce number of generated files for the feature flags system#42820

Closed

rubennorte wants to merge 4 commits into

facebook:mainfrom

rubennorte:export-D53352391

rubennorte commented Feb 2, 2024

Contributor

Summary:
The feature flag system generates a significant amount of files. This reduces that number to remove noise from diffs/PRs by eliminating a file that could be defined privately within another one.

Changelog: [internal]

Differential Revision: D53352391

facebook-github-bot added CLA Signed p: Facebook Partner labels

facebook-github-bot commented Feb 2, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

facebook-github-bot added the fb-exported label

facebook-github-bot commented Feb 2, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from c10d186 to a04b3ce Compare

February 2, 2024 15:26

analysis-bot commented Feb 2, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,233,365	+4,087
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,600,183	+4,090
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 48a19d7
Branch: main

facebook-github-bot commented Feb 2, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from a04b3ce to 509d5f0 Compare

February 2, 2024 15:57

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from 509d5f0 to 52bfbed Compare

February 5, 2024 13:43

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from 52bfbed to 1942b0c Compare

February 5, 2024 14:03

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from 1942b0c to ab609f1 Compare

February 5, 2024 14:11

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from ab609f1 to 6c67109 Compare

February 5, 2024 14:35

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from 6c67109 to 750d6c2 Compare

February 5, 2024 16:43

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from 750d6c2 to bd5b926 Compare

February 5, 2024 17:14

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from bd5b926 to 1f459e7 Compare

February 5, 2024 17:25

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from 1f459e7 to e4096bb Compare

February 5, 2024 17:47

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from e4096bb to b9cc620 Compare

February 5, 2024 17:54

rubennorte and others added 4 commits

February 5, 2024 09:57


          Minor improvements in ReactNativeFeatureFlagsAccessor

84d9c22

Differential Revision: D53416934

fbshipit-source-id: 7cb14fea95712c2528ea04ac532ace9fe7b7a0b3


          Use Flow in feature flags scripts

ae1170d

Differential Revision: D53351484

fbshipit-source-id: b516dfdc3dee66ab746255347cbf83062c92a3a1


          Move feature flag definitions to JS file instead of JSON

276a68b

Differential Revision: D53351483

fbshipit-source-id: 8f1c81f2ca1507c2662d46d9f7955f9a0b3d327e


          Reduce number of generated files for the feature flags system (facebo…

bdfb127

…ok#42820)

Summary:
Pull Request resolved: facebook#42820

The feature flag system generates a significant amount of files. This reduces that number to remove noise from diffs/PRs by eliminating a file that could be defined privately within another one.

Changelog: [internal]

bypass-github-export-checks
(CI is broken on main)

Reviewed By: huntie

Differential Revision: D53352391

fbshipit-source-id: 7ee676f1e0a856012f838871436cb6dec2ad8485

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D53352391

rubennorte force-pushed the export-D53352391 branch from b9cc620 to bdfb127 Compare

February 5, 2024 17:59

facebook-github-bot closed this in

e035005

facebook-github-bot commented Feb 5, 2024

Contributor

This pull request has been merged in e035005.

facebook-github-bot added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner