Add runtime check to ensure feature flags are only overridden once#42825
Closed
rubennorte wants to merge 5 commits into
Closed
Add runtime check to ensure feature flags are only overridden once#42825rubennorte wants to merge 5 commits into
rubennorte wants to merge 5 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
Base commit: e350859 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
d698975 to
c70ebc5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
c70ebc5 to
9dfdd3a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
9dfdd3a to
b680b05
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
b680b05 to
2ddef58
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
2ddef58 to
a46e782
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
a46e782 to
89347a8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
89347a8 to
7007fd9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
7007fd9 to
719c94a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
719c94a to
be1b2c4
Compare
Differential Revision: D53416934 fbshipit-source-id: 0ebfa8cdcbf989aefc9dc679a381d85e53b59a3e
Differential Revision: D53351484 fbshipit-source-id: 0e647c6b67d6c5b2ed5802683d6b43691ec96fb4
Differential Revision: D53351483 fbshipit-source-id: eaa22ba078723ec21dcf30465fb23c91c8139420
Differential Revision: D53352391 fbshipit-source-id: 21ffc65c4a91854a05f2af70b2c2b33eed899880
…eact#42825) Summary: Pull Request resolved: react#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] bypass-github-export-checks (CI is broken on main) Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: ff987cd323800a3786101a31b4dd3dc27294ce77
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
be1b2c4 to
47f9235
Compare
Contributor
|
This pull request has been merged in fd6a6fe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This makes overrides for feature flags more predictable by only allowing a single point of overrides per app.
The previous behavior was:
The new behavior, both for common flags and for JS flags, is to only have a single override.
Changelog: [internal]
Reviewed By: mdvacca
Differential Revision: D53360609