Move CSSTokenizer to "react/renderer/css"#42832
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53377527 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53377527 |
NickGerleman
force-pushed
the
export-D53377527
branch
from
0fc3b42 to
05733d9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53377527 |
NickGerleman
force-pushed
the
export-D53377527
branch
from
05733d9 to
d83f178
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53377527 |
NickGerleman
force-pushed
the
export-D53377527
branch
from
d83f178 to
c301b41
Compare
Summary: Pull Request resolved: facebook#42832 Various analogs to CSS types and utilities currently exist between `core` and `components/view`. These don't really belong well with either, so this adds a top-level "css" library, and moves `CSSTokenizer` there. This is statically linked into Fabric binary on Android OSS. Changelog: [Internal] Reviewed By: rshest Differential Revision: D53377527 fbshipit-source-id: 62888966c597f1865af75ad43dfedfc401a9ab6b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53377527 |
NickGerleman
force-pushed
the
export-D53377527
branch
from
c301b41 to
e322739
Compare
Contributor
|
This pull request has been merged in f63efaf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Various analogs to CSS types and utilities currently exist between
coreandcomponents/view. These don't really belong well with either, so this adds a top-level "css" library, and movesCSSTokenizerthere.This is statically linked into Fabric binary on Android OSS.
Changelog: [Internal]
Differential Revision: D53377527