Mark nullability of RNLog class#42865
Closed
mdvacca wants to merge 11 commits into
Closed
Conversation
Summary: HybridData can not be null, fixing nullability in DefaultTurboModuleManagerDelegate changelog: [internal] internal Differential Revision: D53393139 fbshipit-source-id: 248115e7ef36bf4826f2e1ec39129249449c6798
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393140 fbshipit-source-id: 7ee1fb8086b54bf9826013bb1ff6db6f34f09b4c
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393137 fbshipit-source-id: e1b227f0808e0f0eeb4ed623f56cf9e25cd5c21c
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393141 fbshipit-source-id: 1b3238b4f5e7c39b617695124e5543e5ed06a38d
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393136 fbshipit-source-id: 2b3b5be101a67fe48d6e8731aba72cf9b389425b
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393135 fbshipit-source-id: 6fa91854ed6edcaae01a50532fa753a18607fa35
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393476 fbshipit-source-id: 596c0827ba8ddfb887ed5c44dab431be62138795
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393474 fbshipit-source-id: 3bc9e58b18a071e2c1a93736159eeb0cd82147a5
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393472 fbshipit-source-id: 4fc4f5e8d73fc30efa81dd28f18cf5468c84646c
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Differential Revision: D53393473 fbshipit-source-id: a9d644a92becdc004d31dacd5f7771c066f5a94a
Summary: Mark nullability of RNLog class changelog: [internal] internal Differential Revision: D53393953 fbshipit-source-id: 3cb31b9969454afc20fef938c2324ca979c833aa
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53393953 |
Base commit: fbc090d |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53393953 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53393953 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 7, 2024
Summary: Mark nullability of RNLog class changelog: [internal] internal Reviewed By: cortinico Differential Revision: D53393953
Contributor
|
This pull request has been merged in e2fa62d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mark nullability of RNLog class
changelog: [internal] internal
Differential Revision: D53393953