disable "Open Debugger" menu item if the bundler is disconnected#42876
disable "Open Debugger" menu item if the bundler is disconnected#42876EdmondChuiHW wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
555b90a to
fd38958
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
fd38958 to
1bd092c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
1bd092c to
242e71f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
242e71f to
b577385
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
Base commit: db066ac |
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
b577385 to
1bedcd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
…ct#42876) Summary: Changelog: [Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected # Existing In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected. {F1451833462} # In this PR The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript" {F1451834019} # Reference * Also on iOS: D53354110 Differential Revision: D53428914
EdmondChuiHW
force-pushed
the
export-D53428914
branch
from
1bedcd1 to
fcc97b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53428914 |
|
This pull request was successfully merged by @EdmondChuiHW in 7afc8b8. When will my fix make it into a release? | Upcoming Releases |
3 participants
Summary:
Changelog:
[Android][Fixed] Disable the "Open Debugger" item from dev menu if the bundler is disconnected
Existing
In our dev menu, the "Open Debugger" menu item is shown even if the packager isn't connected.
{F1451833462}
In this PR
The "Open Debugger" menu item is disabled when the packager is disconnected with the message "Connect to the bundler to debug JavaScript"
{F1451834019}
Reference
Differential Revision: D53428914