Fix incorrect cast in RemoveDeleteTree#43018
Closed
javache wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53586565 |
Base commit: 59d46e8 |
Summary: This was introduced to support MapBuffer-based view managers (D33735245), but that experiment has been removed from the codebase (D53072714). This indirection is preventing a proper fix for a crash we're seeing with RemoveDeleteTree (T178300877) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53586567
Summary: Assuming that if View is a ViewGroup, its ViewManager is a ViewGroupManager is incorrect. Custom ViewManagers may use ViewGroups internally to represent complex views exposed to JS. Type-check the ViewManager instead to avoid the crash seen in T178300877 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D53586565
javache
force-pushed
the
export-D53586565
branch
from
8fd6a05 to
010c8f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53586565 |
Contributor
|
This pull request has been merged in 53e3f36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Assuming that if View is a ViewGroup, its ViewManager is a ViewGroupManager is incorrect. Custom ViewManagers may use ViewGroups internally to represent complex views exposed to JS.
Type-check the ViewManager instead to avoid the crash seen in T178300877
Changelog: [Internal]
Differential Revision: D53586565