Skip to content

Cleanup ios_hermes:rn_heap_size_mb#43023

Closed
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D53761942
Closed

Cleanup ios_hermes:rn_heap_size_mb#43023
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D53761942

Conversation

@javache

@javache javache commented Feb 14, 2024

Copy link
Copy Markdown
Member

Summary: Unused mobile config, and is not consistently used across all the many places we can initialize a Hermes instance.

Differential Revision: D53761942

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53761942

@analysis-bot

analysis-bot commented Feb 14, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,935,068 +5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,293,280 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e9351f0
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53761942

Summary:

Unused mobile config, and is not consistently used across all the many places we can initialize a Hermes instance.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D53761942
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53761942

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 20, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in b164302.

@javache javache deleted the export-D53761942 branch February 27, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants