Skip to content

Add missing react_render_core -> runtimeexecutor CMake dep#43028

Closed
motiz88 wants to merge 1 commit into
facebook:mainfrom
motiz88:export-D53767182
Closed

Add missing react_render_core -> runtimeexecutor CMake dep#43028
motiz88 wants to merge 1 commit into
facebook:mainfrom
motiz88:export-D53767182

Conversation

@motiz88

@motiz88 motiz88 commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Summary:
Changelog: [Internal]

Should fix an OSS Android build failure introduced in the stack of D53671483. (Apparently CMake doesn't propagate transitive header dependencies?)

Differential Revision: D53767182

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 14, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53767182

Summary:
Changelog: [Internal]

Should fix an OSS Android build failure introduced in the stack of D53671483. (Apparently CMake doesn't propagate transitive header dependencies?)

Reviewed By: robhogan

Differential Revision: D53767182
@analysis-bot

analysis-bot commented Feb 14, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,828,319 +77,821
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,186,789 +77,801
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 496724f
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D53767182

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 14, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 3020747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants