Make React-jsiinspector depends on hermes-engine to fix Dynamic Frameworks#43081
Closed
cipolleschi wants to merge 1 commit into
Closed
Make React-jsiinspector depends on hermes-engine to fix Dynamic Frameworks#43081cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53901016 |
…works (facebook#43081) Summary: When Hermes i used, it is hermes that provides JSI to React Native and not React-jsi. This is required to fix the ODR violatons. Dynamic frameworks requires that all the dependencies are declared explicitly, and missing the `hermes-engine` dependency was breaking the dependency graph. ## Changelog [Internal] - Make JSIInspector depends o hermes-engine Differential Revision: D53901016
cipolleschi
force-pushed
the
export-D53901016
branch
from
d1f10f7 to
296e51c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53901016 |
Contributor
|
This pull request has been merged in 475a156. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When Hermes i used, it is hermes that provides JSI to React Native and not React-jsi.
This is required to fix the ODR violatons.
Dynamic frameworks requires that all the dependencies are declared explicitly, and missing the
hermes-enginedependency was breaking the dependency graph.Changelog
[Internal] - Make JSIInspector depends o hermes-engine
Differential Revision: D53901016