Prevent reporting mount when FabricUIManager has been destroyed#43099
Closed
rubennorte wants to merge 1 commit into
Closed
Prevent reporting mount when FabricUIManager has been destroyed#43099rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53920863 |
Base commit: a4d6be8 |
rubennorte
force-pushed
the
export-D53920863
branch
from
1436d92 to
3973bbc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53920863 |
…book#43099) Summary: In all methods of FabricUIManager we check whether it's been destroyed before doing any logic, but we don't in this asynchronous method we're scheduling to report mounts. This adds the check in that case as well to potentially fix some crashes we're seeing in current experiments for mount hooks on Android. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D53920863
rubennorte
force-pushed
the
export-D53920863
branch
from
3973bbc to
71de76d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53920863 |
Contributor
|
This pull request has been merged in 1fc2a5a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In all methods of FabricUIManager we check whether it's been destroyed before doing any logic, but we don't in this asynchronous method we're scheduling to report mounts.
This adds the check in that case as well to potentially fix some crashes we're seeing in current experiments for mount hooks on Android.
Changelog: [internal]
Differential Revision: D53920863