react-native | Allow invoking a sync callback under AsyncCallback via 'unsafeCallSync'.#43143
Closed
nlutsenko wants to merge 1 commit into
Closed
react-native | Allow invoking a sync callback under AsyncCallback via 'unsafeCallSync'.#43143nlutsenko wants to merge 1 commit into
nlutsenko wants to merge 1 commit into
Conversation
… 'unsafeCallSync'. Summary: AsyncCallback allows storing SyncCallback and invoking it from any thread. However, there are cases where if you have a mix of sync and async callbacks - you might want to invoke them together in one go, instead of spreading them out across thread invocations. For those cases - allow invoking any AsyncCallback as a sync one, prefixing it with "unsafe", because it's inherently not a safe operation to perform. Changelog: [General][Changed] - Allow invoking the AsyncCallback synchronously to allow for tight performance optimization. Reviewed By: s-rws Differential Revision: D54028850
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54028850 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54028850 |
nlutsenko
added a commit
to nlutsenko/react-native
that referenced
this pull request
Feb 22, 2024
… 'unsafeCallSync'. (facebook#43144) Summary: Pull Request resolved: facebook#43144 Pull Request resolved: facebook#43143 AsyncCallback allows storing SyncCallback and invoking it from any thread. However, there are cases where if you have a mix of sync and async callbacks - you might want to invoke them together in one go, instead of spreading them out across thread invocations. For those cases - allow invoking any AsyncCallback as a sync one, prefixing it with "unsafe", because it's inherently not a safe operation to perform. Changelog: [General][Changed] - Allow invoking the AsyncCallback synchronously to allow for tight performance optimization. Reviewed By: s-rws Differential Revision: D54028850
Base commit: a1171f7 |
Contributor
|
This pull request has been merged in 765e542. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AsyncCallback allows storing SyncCallback and invoking it from any thread.
However, there are cases where if you have a mix of sync and async callbacks - you might want to invoke them together in one go, instead of spreading them out across thread invocations.
For those cases - allow invoking any AsyncCallback as a sync one, prefixing it with "unsafe", because it's inherently not a safe operation to perform.
Changelog:
[General][Changed] - Allow invoking the AsyncCallback synchronously to allow for tight performance optimization.
Reviewed By: s-rws
Differential Revision: D54028850