Stop catching IllegalArgumentException in ReactPackageTurboModuleManagerDelegate#43152
Closed
javache wants to merge 1 commit into
Closed
Stop catching IllegalArgumentException in ReactPackageTurboModuleManagerDelegate#43152javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54068429 |
Base commit: 2dc39c2 |
…gerDelegate (facebook#43152) Summary: Now that 0.74 has been cut, we can drop this warning and let the exception bubble up. In facebook#41509 we stopped masking this. Changelog: [Android][Changed] Throwing IllegalArgumentException from ReactPackage is no longer suppressed Reviewed By: cortinico, cipolleschi Differential Revision: D54068429
javache
force-pushed
the
export-D54068429
branch
from
a88d1f7 to
870c2f8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54068429 |
Contributor
|
This pull request has been merged in 2584bcb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now that 0.74 has been cut, we can drop this warning and let the exception bubble up.
In #41509 we stopped masking this.
Changelog: [Android][Changed] Throwing IllegalArgumentException from ReactPackage is no longer suppressed
Reviewed By: cortinico, cipolleschi
Differential Revision: D54068429