Skip to content

Mark classes of package uimanager as @Nullsafe #43155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 2 commits into from
Closed

Mark classes of package uimanager as @Nullsafe #43155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
531958c
Validate textAttributeProps is created with a non-null textAttributes…
mdvacca Feb 23, 2024
5f7c572
Mark classes of package uimanager as @Nullsafe (#43155)
mdvacca Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolverManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@

package com.facebook.react.uimanager;

import com.facebook.infer.annotation.Nullsafe;
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.proguard.annotations.DoNotStripAny;
import com.facebook.react.bridge.RuntimeExecutor;
import com.facebook.soloader.SoLoader;

@Nullsafe(Nullsafe.Mode.LOCAL)
@DoNotStripAny
public class ComponentNameResolverManager {

Expand Down
2 changes: 2 additions & 0 deletions ...ative/ReactAndroid/src/main/java/com/facebook/react/uimanager/FabricViewStateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import androidx.annotation.Nullable;
import com.facebook.common.logging.FLog;
import com.facebook.infer.annotation.Nullsafe;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableMap;

Expand All @@ -24,6 +25,7 @@
* retrying the UpdateState call until it succeeds; or you call setState again; or the View layer is
* updated with a newer StateWrapper.
*/
@Nullsafe(Nullsafe.Mode.LOCAL)
@Deprecated(
since =
"Deprecated class since v0.73.0, please use com.facebook.react.uimanager.StateWrapper instead.",
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FloatUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

package com.facebook.react.uimanager;

import com.facebook.infer.annotation.Nullsafe;

@Nullsafe(Nullsafe.Mode.LOCAL)
public class FloatUtil {

private static final float EPSILON = .00001f;
Expand Down
8 changes: 6 additions & 2 deletions .../ReactAndroid/src/main/java/com/facebook/react/views/text/fragments/BridgeTextFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ import com.facebook.react.views.text.TextAttributeProps
/** A [TextFragment] implementation backed by a a [ReadableMap] */
internal class BridgeTextFragment(private val fragment: ReadableMap) : TextFragment {
override val textAttributeProps: TextAttributeProps
get() =
TextAttributeProps.fromReadableMap(ReactStylesDiffMap(fragment.getMap("textAttributes")))
get() {
val textAttributesMap =
fragment.getMap("textAttributes")
?: throw IllegalStateException("Missing required field `textAttributes`")
return TextAttributeProps.fromReadableMap(ReactStylesDiffMap(textAttributesMap))
}

override val string: String?
get() = fragment.getString("string")
Expand Down