Skip to content

Mark classes of package uimanager as @Nullsafe#43156

Closed
mdvacca wants to merge 3 commits into
facebook:mainfrom
mdvacca:export-D54027185
Closed

Mark classes of package uimanager as @Nullsafe#43156
mdvacca wants to merge 3 commits into
facebook:mainfrom
mdvacca:export-D54027185

Conversation

@mdvacca

@mdvacca mdvacca commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Summary:
All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D54027185

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D54027185

@analysis-bot

analysis-bot commented Feb 22, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,000,692 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,359,072 +8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 073ca1a
Branch: main

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 22, 2024
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D54027185
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 22, 2024
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D54027185
…Attributes map (facebook#42932)

Summary:

Validate textAttributeProps is created with a non-null textAttributes map

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D53558784
)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D54027178
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D54027185
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D54027185

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 23, 2024
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D54027185
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 23, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in c77c13a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants