Mark IViewGroupManager interface as @Nullsafe#43157
Closed
mdvacca wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54034058 |
Base commit: 073ca1a |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 22, 2024
Summary: IViewGroupManager is NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: rshest Differential Revision: D54034058
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 22, 2024
Summary: IViewGroupManager is NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: rshest Differential Revision: D54034058
mdvacca
force-pushed
the
export-D54034058
branch
from
828f127 to
24b27c1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54034058 |
… map (facebook#42932) Summary: Validate textAttributeProps is created with a non-null textAttributes map changelog: [internal] internal Reviewed By: rshest Differential Revision: D53558784
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D54027178
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: javache Differential Revision: D54027185
Summary: IViewGroupManager is NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future bypass-github-export-checks changelog: [internal] internal Reviewed By: rshest Differential Revision: D54034058
mdvacca
force-pushed
the
export-D54034058
branch
from
24b27c1 to
ed62382
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54034058 |
Contributor
|
This pull request has been merged in 52a70d7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
IViewGroupManager is NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future
changelog: [internal] internal
Reviewed By: rshest
Differential Revision: D54034058