Register CatalystInstanceImpl with modern CDP backend#43251
Closed
huntie wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51458010 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51458010 |
huntie
force-pushed
the
export-D51458010
branch
from
2c1cd4a to
e9f67ea
Compare
…facebook#43250) Summary: Integrates the modern CDP backend with `ReactInstanceManager` on Android. `ReactInstanceManager` is equivalent to the CDP page / `HostTarget` concept, therefore we register the `addPage`/`removePage` calls with this object's lifecycle. Implementation notes: - `ReactInstanceManagerInspectorTarget` is created to avoid converting `ReactInstanceManager` to JNI (impacting tests). - Its constructor receives a `TargetDelegate` object, so that we avoid passing the entire `ReactInstanceManager` class through (avoids cyclic dependency from `com.facebook.react.bridge` to `com.facebook.react`). Changelog: [Internal] - Register `ReactInstanceManager` with modern CDP backend Reviewed By: motiz88 Differential Revision: D51456960
…#43251) Summary: Integrates the modern CDP backend with `CatalystInstanceImpl` (the React Native instance implementation) on Android. This complete the modern CDP integration for Bridge. Changelog: [Internal] Differential Revision: D51458010
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51458010 |
huntie
force-pushed
the
export-D51458010
branch
from
e9f67ea to
159f5ec
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51458010 |
Contributor
|
This pull request has been merged in bfb0319. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Integrates the modern CDP backend with
CatalystInstanceImpl(the React Native instance implementation) on Android.This complete the modern CDP integration for Bridge.
Changelog: [Internal]
Differential Revision: D51458010