Skip to content

Do not publish src/**/__tests__ folder for react-native#43261

Closed
cortinico wants to merge 1 commit into
mainfrom
nc/do-not-publish-tests
Closed

Do not publish src/**/__tests__ folder for react-native#43261
cortinico wants to merge 1 commit into
mainfrom
nc/do-not-publish-tests

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:

We should not be publishing the __tests__ folder to the npm package.
Fixes #43242

Changelog:

[INTERNAL] [CHANGED] - Do not publish src/**/tests for react-native

Test Plan:

Nothing to test

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 1, 2024
@NickGerleman

Copy link
Copy Markdown
Contributor

Probably should be grouped with the existing globs of files to pack (and ignore).

"!scripts/codegen/__tests__",

@jonthysell

Copy link
Copy Markdown
Contributor

Yeah I'm curious, as the old folder /packages/react-native/Libraries/DOM/OldStyleCollections/__tests__ wasn't published before (none of the __tests__ folders under Libraries\ are) yet I can't find an .npmignore nor a file ignore in package.json that explains it.

@cortinico

Copy link
Copy Markdown
Contributor Author

yet I can't find an .npmignore nor a file ignore in package.json that explains it.

@jonthysell it's this one:

@NickGerleman I really dislike we do have a mixture of .npmignore and glob exclusions in the package.json. Let's merge this one and clean things up afterwards?

@cortinico

Copy link
Copy Markdown
Contributor Author

/rebase

@github-actions github-actions Bot force-pushed the nc/do-not-publish-tests branch from 176d4bd to 72b31c4 Compare March 5, 2024 15:17
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,024,925 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,383,284 -12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: cdb2ff9
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 6, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in e1702f4.

@cortinico cortinico deleted the nc/do-not-publish-tests branch June 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests moved from Libraries to src/private are now being published in the NPM package

5 participants