feat: RCTConvert to support UIModalPresentationStyle

[vonovak]

Summary:

Currently, the ability to convert JS values to UIModalPresentationStyle is not present directly on RCTConvert.

In the RN code base itself, there's not a lot of need to do this type of conversion, but in community modules, presenting ViewControllers can be a fairly common scenario and it'd be nice to be able to use this conversion directly from RCTConvert, rather than from RCTModalHostViewManager, as it'd improve its "discoverability" and consistency.

If someone relied on this, then it's technically speaking a breaking change but I'd say it's for the better, and searching #import <React/RCTModalHostViewManager.h> on github doesn't reveal a lot of results.

Changelog:

[IOS] [ADDED] - RCTConvert to support UIModalPresentationStyle

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Test Plan:

Tested using RN Tester

modal_presentation.mp4

[cipolleschi]

Hi @vonovak, thanks for the contribution. If we can make it non breaking, it would be better, I left a comment in the file.

[cipolleschi]

We can make it non-breaking by leaving this import here, right?

[vonovak]

@cipolleschi yes, that works, I've put it back. 👍

[cipolleschi]

To set expectations: I'm going to be on PTO from tomorrow until the 28th of March.
I'll not import this PR myself, so that our internal pinging tool can ping someone else that can champion this PR on my behalf.

Perhaps @dmytrorykun or @sammy-SC can help.

[dmytrorykun]

@vonovak could you please rebase on the latest main. The CI failures seem unrelated to you changes, and will likely go away.

[vonovak]

@vonovak could you please rebase on the latest main. The CI failures seem unrelated to you changes, and will likely go away.

@dmytrorykun CI is now green

[facebook-github-bot]

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@dmytrorykun merged this pull request in 2d547a3.