Add FilterHelper to get all RenderEffects needed to apply filters#43357
Closed
joevilches wants to merge 1 commit into
Closed
Add FilterHelper to get all RenderEffects needed to apply filters#43357joevilches wants to merge 1 commit into
joevilches wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54603892 |
joevilches
force-pushed
the
export-D54603892
branch
from
b7e9410 to
e27ffa1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54603892 |
Base commit: ff03b14 |
joevilches
force-pushed
the
export-D54603892
branch
from
e27ffa1 to
59737ba
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54603892 |
joevilches
force-pushed
the
export-D54603892
branch
from
59737ba to
3a22e71
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54603892 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Mar 13, 2024
…ilters (facebook#43357) Summary: This diff adds a class to get the needed RenderEffects to support CSS filters on Android. This diff does not add any of the plumbing for it to actually work, that comes in the next diff, but I figured this was complicated and isolated enough to be on its own. Note that I did not add blur or drop shadow as those are a bit more involved and I plan on adding them later. Changelog: [Internal] Reviewed By: javache Differential Revision: D54603892
…cebook#43357) Summary: This diff adds a class to get the needed RenderEffects to support CSS filters on Android. This diff does not add any of the plumbing for it to actually work, that comes in the next diff, but I figured this was complicated and isolated enough to be on its own. Note that I did not add blur or drop shadow as those are a bit more involved and I plan on adding them later. Changelog: [Internal] Reviewed By: javache Differential Revision: D54603892
joevilches
force-pushed
the
export-D54603892
branch
from
3a22e71 to
08dda04
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54603892 |
Contributor
|
This pull request has been merged in 5c58811. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a class to get the needed RenderEffects to support CSS filters on Android. This diff does not add any of the plumbing for it to actually work, that comes in the next diff, but I figured this was complicated and isolated enough to be on its own.
Note that I did not add blur or drop shadow as those are a bit more involved and I plan on adding them later.
Changelog: [Internal]
Differential Revision: D54603892