Skip to content

Remove createRootView(initialProps) from ReactDelegate#43365

Closed
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D54434648
Closed

Remove createRootView(initialProps) from ReactDelegate#43365
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D54434648

Conversation

@javache

@javache javache commented Mar 7, 2024

Copy link
Copy Markdown
Member

Summary: Changelog: [Android][Changed] Simplified ReactActivityDelegate to expose a single createRootView method.

Differential Revision: D54434648

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 7, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D54434648

Summary:

Changelog: [Android][Changed] Simplified ReactActivityDelegate to expose a single createRootView method.

Reviewed By: cortinico

Differential Revision: D54434648
@javache javache force-pushed the export-D54434648 branch from 720ee7b to 0e570e7 Compare March 8, 2024 15:11
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D54434648

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,016,584 +4,074
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,371,033 -12
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4adef35
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 11, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 3283202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants