add support for text highlighting#43386
Closed
mightyaleksey wants to merge 1 commit into
Closed
Conversation
Summary: Changes: - fixes `RCTAttributedTextUtils` to set `RCTAttributedStringIsHighlightedAttributeName` attribute according to `isHighlighted` textAttribute value. - adds block to `drawAttributedString` and passed highlighted bezier curve to it. - updates `drawRect` to visually highlight selected text. ## Changelog: [iOS][Fixed] - Fixed text highlighting in the New Architecture Reviewed By: sammy-SC Differential Revision: D54594472
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54594472 |
Base commit: 4adef35 |
Contributor
|
This pull request has been merged in eadcebb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changes:
RCTAttributedTextUtilsto setRCTAttributedStringIsHighlightedAttributeNameattribute according toisHighlightedtextAttribute value.drawAttributedStringand passed highlighted bezier curve to it.drawRectto visually highlight selected text.Changelog:
[iOS][Fixed] - Fixed text highlighting in the New Architecture
Reviewed By: sammy-SC
Differential Revision: D54594472