Update InspectorFlags to lazily pull upstream values#43390
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54684692 |
Summary: Refactor after D54639775. This avoids the unfortunate side effect where `InspectorFlags::dangerouslyResetFlags()` would immediately reread `ReactNativeFeatureFlags `. This call is now relocated in our test util. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D54684692
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54684692 |
Base commit: 7bb204a |
Contributor
|
This pull request has been merged in 8089146. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor after D54639775. This avoids the unfortunate side effect where
InspectorFlags::dangerouslyResetFlags()would immediately rereadReactNativeFeatureFlags. This call is now relocated in our test util.Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D54684692