Update feature flag generator to create directories for generated files before writing#43393
Closed
rubennorte wants to merge 1 commit into
Closed
Update feature flag generator to create directories for generated files before writing#43393rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54690126 |
Base commit: e2157f0 |
rubennorte
force-pushed
the
export-D54690126
branch
from
ea151b1 to
5ef62bf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54690126 |
rubennorte
force-pushed
the
export-D54690126
branch
from
5ef62bf to
740948d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54690126 |
…es before writing (facebook#43393) Summary: Changelog: [internal] The generator doesn't create intermediate directories, which is causing issues now that we're moving the generated native module spec to a new directory. This fixes that. Differential Revision: D54690126
rubennorte
force-pushed
the
export-D54690126
branch
from
740948d to
ecf8647
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Mar 11, 2024
…erated files before writing (facebook#43393) Summary: Changelog: [internal] The generator doesn't create intermediate directories, which is causing issues now that we're moving the generated native module spec to a new directory. This fixes that. Differential Revision: D54690126
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54690126 |
Contributor
|
This pull request has been merged in 2830066. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The generator doesn't create intermediate directories, which is causing issues now that we're moving the generated native module spec to a new directory.
This fixes that.
Differential Revision: D54690126