Allow accessing common feature flags before setting overrides for JS-only overrides#43394
Closed
rubennorte wants to merge 2 commits into
Closed
Allow accessing common feature flags before setting overrides for JS-only overrides#43394rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54687055 |
Base commit: e2157f0 |
rubennorte
force-pushed
the
export-D54687055
branch
from
b43a113 to
4482f07
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54687055 |
rubennorte
force-pushed
the
export-D54687055
branch
from
4482f07 to
a5f9603
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54687055 |
…erated files before writing (facebook#43393) Summary: Changelog: [internal] The generator doesn't create intermediate directories, which is causing issues now that we're moving the generated native module spec to a new directory. This fixes that. Differential Revision: D54690126
…only overrides (facebook#43394) Summary: Changelog: [internal] When we built the new feature flag system we added a constraint in the JS API to prevent calling `override` if any of the flags was already accessed from JS. This is very restrictive because it doesn't allow us to access common flags (like `enableMicrotasks`) set up from native during the initialization of the framework because then applications wouldn't be able to set JS-only overrides. This relaxes the constraint to disallow accessing JS-only flags before setting JS-only overrides, but accessing common (native) flags before that is ok. Differential Revision: D54687055
rubennorte
force-pushed
the
export-D54687055
branch
from
a5f9603 to
212b761
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54687055 |
Contributor
|
This pull request has been merged in 9c9c7ed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
When we built the new feature flag system we added a constraint in the JS API to prevent calling
overrideif any of the flags was already accessed from JS.This is very restrictive because it doesn't allow us to access common flags (like
enableMicrotasks) set up from native during the initialization of the framework because then applications wouldn't be able to set JS-only overrides.This relaxes the constraint to disallow accessing JS-only flags before setting JS-only overrides, but accessing common (native) flags before that is ok.
Differential Revision: D54687055