Fix TimingModuleTest in OSS#43422
Closed
javache wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54776392 |
javache
force-pushed
the
export-D54776392
branch
from
08080e4 to
0ba1e41
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54776392 |
javache
force-pushed
the
export-D54776392
branch
from
0ba1e41 to
45c88b5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54776392 |
Base commit: 7c5a014 |
Summary: After my changes in D54496604, this test now requires the main looper to progress as well, to dispatch the right callback. Changelog: [Internal] Reviewed By: rshest Differential Revision: D54776392
javache
force-pushed
the
export-D54776392
branch
from
45c88b5 to
8d9cfd8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54776392 |
Contributor
|
This pull request has been merged in 9e2bb4e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D54776392
After my changes in 641a9c4?, this test now requires the main looper to progress as well, to dispatch the right callback.
Changelog: [Internal]