Skip to content

change: replace twitter with x#43423

Closed
kolyaVV wants to merge 3 commits into
facebook:mainfrom
kolyaVV:main
Closed

change: replace twitter with x#43423
kolyaVV wants to merge 3 commits into
facebook:mainfrom
kolyaVV:main

Conversation

@kolyaVV

@kolyaVV kolyaVV commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

Summary:

When users create a new app, there is an option: Follow us on Twitter with the description. Twitter is X now.
twitter

Changelog: [Internal]

Replace the Twitter link, title, and description with X.

Test Plan:

Set the environment for React Native app and then npx react-native@latest init AwesomeProject, npm start, and npm run ios

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @kolyaVV!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@kolyaVV kolyaVV marked this pull request as draft March 12, 2024 01:52
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2024
@kolyaVV kolyaVV marked this pull request as ready for review March 12, 2024 01:52
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 12, 2024

@huntie huntie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! Can I suggest updating the changelog line in your summary to Changelog: [Internal] (small enough change to omit IMO, although a user facing change).

Comment thread packages/react-native/Libraries/NewAppScreen/components/LearnMoreLinks.js Outdated
@kolyaVV kolyaVV requested a review from huntie March 12, 2024 21:02
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 13, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@huntie merged this pull request in 5807ada.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants