Add enableHermesCDPAgent case to ReactInstanceIntegrationTest#43436
Closed
huntie wants to merge 1 commit into
Closed
Add enableHermesCDPAgent case to ReactInstanceIntegrationTest#43436huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54801168 |
…ok#43436) Summary: ## Context We are migrating to the new Hermes `CDPAgent` and `CDPDebugAPI` APIs in the modern CDP server (previously `HermesCDPHandler`). ## This diff Expands test coverage for the Hermes `CDPAgent` implementation by enabling in `ReactInstanceIntegrationTest`. Changelog: [Internal] bypass-github-export-checks Reviewed By: motiz88 Differential Revision: D54801168
huntie
force-pushed
the
export-D54801168
branch
from
e5f3b16 to
7d0d5a4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54801168 |
Contributor
|
This pull request has been merged in e2c5a36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
We are migrating to the new Hermes
CDPAgentandCDPDebugAPIAPIs in the modern CDP server (previouslyHermesCDPHandler).This diff
Expands test coverage for the Hermes
CDPAgentimplementation by enabling inReactInstanceIntegrationTest.Changelog: [Internal]
bypass-github-export-checks
Reviewed By: motiz88
Differential Revision: D54801168