Skip to content

Re-enable stale execution context test under new Hermes CDP Agent #43444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robhogan wants to merge 1 commit into from
Closed

Re-enable stale execution context test under new Hermes CDP Agent #43444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/react-native/ReactCommon/jsinspector-modern/tests/JsiIntegrationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,7 @@ TYPED_TEST(JsiIntegrationHermesTest, EvaluateExpression) {
})");
}

// TODO(T181299386): Restore stale execution context validation under
// HermesRuntimeAgentDelegateNew
TYPED_TEST(
JsiIntegrationHermesLegacyTest,
EvaluateExpressionInExecutionContext) {
TYPED_TEST(JsiIntegrationHermesTest, EvaluateExpressionInExecutionContext) {
this->connect();

InSequence s;
Expand Down Expand Up @@ -546,8 +542,14 @@ TYPED_TEST(
this->reload();

// Now the old execution context is stale.
this->expectMessageFromPage(
JsonParsed(AllOf(AtJsonPtr("/id", 3), AtJsonPtr("/error/code", -32000))));
this->expectMessageFromPage(JsonParsed(AllOf(
AtJsonPtr("/id", 3),
AtJsonPtr(
"/error/code",
// HermesRuntimeAgentDelegateNew responds more correctly with -32600
// (invalid request), old responds -32000 (server error). Accept
// either.
AnyOf(-32600, -32000)))));
this->toPage_->sendMessage(sformat(
R"({{
"id": 3,
Expand Down