Update test to validate Debugger domain persistence#43446
Closed
huntie wants to merge 5 commits into
Closed
Conversation
Differential Revision: D54630591
Differential Revision: D54712525
Summary: ## Context We are migrating to the new Hermes `CDPAgent` and `CDPDebugAPI` APIs in the modern CDP server (previously `HermesCDPHandler`). ## This diff Following D54712525, add a test case that validates `"Debugger.enable"` is persisted between reloads. This has been actioned by creating a further test group, `ModernHermesVariants`, and scoping the existing `ResolveBreakpointAfterReload` to this, with the removed second `"Debugger.enable"` message. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D54808212
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54808212 |
Contributor
|
This pull request has been merged in 4f10f30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
We are migrating to the new Hermes
CDPAgentandCDPDebugAPIAPIs in the modern CDP server (previouslyHermesCDPHandler).This diff
Following D54712525, add a test case that validates
"Debugger.enable"is persisted between reloads. This has been actioned by creating a further test group,ModernHermesVariants, and scoping the existingResolveBreakpointAfterReloadto this, with the removed second"Debugger.enable"message.Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D54808212