Add missing dependency from AndroidTextInput#43448
Closed
rshest wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54807518 |
Summary: ## Changelog: [Internal] - This adds a stub for `TextLayoutManager.measureCachedSpannableById`, as well as a missing explicit dependency to `jni/react/jni` from the `TextInput` implementation on the Android platform. This is required in order for certain build configurations to compile. Differential Revision: D54807518
rshest
force-pushed
the
export-D54807518
branch
from
8c5605e to
43f6d51
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54807518 |
Contributor
|
This pull request has been merged in 3bbe193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This adds a stub for
TextLayoutManager.measureCachedSpannableById, as well as a missing explicit dependency tojni/react/jnifrom theTextInputimplementation on the Android platform.This is required in order for certain build configurations to compile.
Differential Revision: D54807518