Switch to Hermes lazy compilation mode in JsiIntegrationTest#43461
Closed
huntie wants to merge 1 commit into
Closed
Switch to Hermes lazy compilation mode in JsiIntegrationTest#43461huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
Summary: Updates `JsiIntegrationTestHermesWithCDPAgentEngineAdapter` to align with `hermes::makeHermesRuntime()` creation since D54686192 (lazy compilation mode, related to recent repeat `Debugger.scriptParsed` bug). Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D54852326
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54852326 |
Base commit: 38cbc08 |
Contributor
|
This pull request has been merged in c0e84ec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updates
JsiIntegrationTestHermesWithCDPAgentEngineAdapterto align withhermes::makeHermesRuntime()creation since D54686192 (lazy compilation mode, related to recent repeatDebugger.scriptParsedbug).Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D54852326