Fix auto-download of CMake#43511
Closed
fabriziocucci wants to merge 1 commit into
Closed
Conversation
Summary: Changelog: [Internal] This is an attempt to fix [facebook#39783](facebook#39783). It seems that when `configureBuildForHermes` runs (as part of `yarn android` in `rn-tester`) cmake may not be available and is not installed automatically: * for 3p, even after installing the latest Android Studio, cmake 3.22.1 is not available by default but needs to be installed manually * for Meta employees, same story when looking at the `ANDROID_HOME` set by the `setup_fb4a.sh` in the `.zshrc` file: ``` # added by setup_fb4a.sh export ANDROID_SDK=/opt/android_sdk export ANDROID_NDK_REPOSITORY=/opt/android_ndk export ANDROID_HOME=${ANDROID_SDK} export PATH=${PATH}:${ANDROID_SDK}/emulator:${ANDROID_SDK}/tools:${ANDROID_SDK}/tools/bin:${ANDROID_SDK}/platform-tools ``` This diff introduces an explicit task to install cmake. ### ALTERNATIVE 1 See D54897379. ### ALTERNATIVE 2 Suggested by cortinico: > Create a mini module called :packages:react-native:ReactAndroid:hermes-engine:cmake-downloader which just triggers an empty cmake build via Android SDK Differential Revision: D54859484
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54859484 |
Base commit: fb42a55 |
Contributor
|
This pull request has been merged in f2c335a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This is an attempt to fix #39783.
It seems that when
configureBuildForHermesruns (as part ofyarn androidinrn-tester) cmake may not be available and is not installed automatically:ANDROID_HOMEset by thesetup_fb4a.shin the.zshrcfile:This diff introduces an explicit task to install cmake.
ALTERNATIVE 1
See D54897379.
ALTERNATIVE 2
Suggested by cortinico:
Differential Revision: D54859484