Implement UI consistency in DOM methods#43577

Closed

rubennorte wants to merge 2 commits into

facebook:mainfrom

rubennorte:export-D55077311

rubennorte commented Mar 20, 2024

Contributor

Summary:
Changelog: [Internal]

This updates all the DOM APIs in React Native (defined in the NativeDOM native module) to make use of the UI consistency mechanism introduced in Fabric (if available, otherwise the behavior is the same we have now — we consume the latest version of the tree available).

As part of that work, this creates a new DOMMethods class that implements all methods using purely C++ APIs (not JSI), moves a lot of logic that was specific for this functionality from UIManager to DOMMethods and modifies NativeDOM to use this new class.

This should make it easier to add unit tests for DOMMethods in the future.

Differential Revision: D55077311

facebook-github-bot added CLA Signed p: Facebook Partner labels

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

facebook-github-bot added the fb-exported label

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 73db4ed to bd2562c Compare

March 20, 2024 18:23

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from bd2562c to 39b1247 Compare

March 20, 2024 18:57

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 39b1247 to dc50f83 Compare

March 20, 2024 19:42

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from dc50f83 to fa6895c Compare

March 20, 2024 19:47

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from fa6895c to 769c6b4 Compare

March 20, 2024 23:38

analysis-bot commented Mar 21, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,437,997	+266,649
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,807,227	+266,745
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 274faf4
Branch: main

rubennorte force-pushed the export-D55077311 branch from 769c6b4 to 24fa444 Compare

March 21, 2024 10:32

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

1 similar comment

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 24fa444 to 26a6788 Compare

March 21, 2024 10:39

rubennorte force-pushed the export-D55077311 branch from 26a6788 to 8259044 Compare

March 21, 2024 11:30

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 8259044 to d5defbd Compare

March 21, 2024 11:37

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from d5defbd to e860cfc Compare

March 21, 2024 11:46

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from e860cfc to 2fa7cde Compare

March 21, 2024 14:31

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 2fa7cde to 41f4d24 Compare

March 21, 2024 14:40

facebook-github-bot commented Mar 22, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 41f4d24 to 3a347d1 Compare

March 22, 2024 16:12

rubennorte force-pushed the export-D55077311 branch from 3a347d1 to 7f28a10 Compare

March 22, 2024 16:20

facebook-github-bot commented Mar 22, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

1 similar comment

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 7f28a10 to 0bf1c6b Compare

March 25, 2024 11:21

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 0bf1c6b to 56a4702 Compare

March 25, 2024 12:00

rubennorte and others added 2 commits

March 25, 2024 05:04


          Implement UI consistency in JS thread

ef0d4bd

Differential Revision: D55024832


          Implement UI consistency in DOM methods (facebook#43577)

44cfc1b

Summary:
Pull Request resolved: facebook#43577

Changelog: [Internal]

This updates all the DOM APIs in React Native (defined in the `NativeDOM` native module) to make use of the UI consistency mechanism introduced in Fabric (if available, otherwise the behavior is the same we have now — we consume the latest version of the tree available).

As part of that work, this creates a new `DOMMethods` class that implements all methods using purely C++ APIs (not JSI), moves a lot of logic that was specific for this functionality from `UIManager` to `DOMMethods` and modifies `NativeDOM` to use this new class.

This should make it easier to add unit tests for `DOMMethods` in the future.

Reviewed By: NickGerleman

Differential Revision: D55077311

rubennorte force-pushed the export-D55077311 branch from 56a4702 to 44cfc1b Compare

March 25, 2024 12:06

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077311

facebook-github-bot closed this in

67d6d09

facebook-github-bot added the Merged label

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request has been merged in 67d6d09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner